Use library's BaseScreenshotTestRunner directly, drop redundant deps#54
Open
EmilioBejasa wants to merge 5 commits intomainfrom
Open
Use library's BaseScreenshotTestRunner directly, drop redundant deps#54EmilioBejasa wants to merge 5 commits intomainfrom
EmilioBejasa wants to merge 5 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Developers no longer need to create StoryRendererActivity or StoryScreenshotTest — both are now provided by the library. - Register BaseStoryRendererActivity in the library manifest so it is merged into the app manifest automatically via Gradle - Add concrete StoryScreenshotTest to the library using BaseStoryRendererActivity directly - Remove StoryRendererActivity.kt, StoryScreenshotTest.kt, and the activity entry from the app manifest Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The library exposes its test infrastructure dependencies via `api`, so consumers don't need to list them explicitly. Replace the one-line ScreenshotTestRunner subclass with a direct reference to the library's BaseScreenshotTestRunner as the testInstrumentationRunner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScreenshotTestRunnersubclass with a direct reference tocom.rnstorybookautoscreenshots.BaseScreenshotTestRunneras thetestInstrumentationRunnerandroidTestImplementationlines forandroidx.test.*andscreenshot-tests-for-android— these are already transitive via the library'sapidepsWhy
This demonstrates the minimal setup a library consumer actually needs. The only test-infrastructure entry in
build.gradleis now:Test plan
./gradlew :app:assembleDebugAndroidTest— BUILD SUCCESSFUL./gradlew :app:connectedDebugAndroidTest— 6/6 tests passed on emulator🤖 Generated with Claude Code