Commit screenshot baselines and un-ignore them in .gitignore#55
Open
EmilioBejasa wants to merge 1 commit intotidy/library-provides-test-activityfrom
Open
Commit screenshot baselines and un-ignore them in .gitignore#55EmilioBejasa wants to merge 1 commit intotidy/library-provides-test-activityfrom
EmilioBejasa wants to merge 1 commit intotidy/library-provides-test-activityfrom
Conversation
Allow android/app/screenshots/*.png through the gitignore so baselines can be committed and local verify has something to compare against. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!android/app/screenshots/*.pngexception to.gitignoreso baseline screenshots can be committedWhy
Previously
*.pngwas gitignored globally, meaningverifyDebugAndroidTestScreenshotTesthad no committed baseline to compare against — it only passed because record and verify ran back-to-back in the same session. Now baselines live in the repo and verify does real pixel comparison.Test plan
verifyDebugAndroidTestScreenshotTestfailed with aVerifyError🤖 Generated with Claude Code