Delete manual ScreenshotTest — superseded by StoryScreenshotTest#59
Open
EmilioBejasa wants to merge 4 commits intomainfrom
Open
Delete manual ScreenshotTest — superseded by StoryScreenshotTest#59EmilioBejasa wants to merge 4 commits intomainfrom
EmilioBejasa wants to merge 4 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ScreenshotTest manually recreated React Native components as native Android views to screenshot them. StoryScreenshotTest now covers all the same stories (Timer, CoinFlip, MyFeature, SwitchFeature) by rendering them through Storybook directly, which is both simpler and more accurate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
ScreenshotTest.kt(~500 lines), which manually recreated React Native components as native Android views to screenshot them.StoryScreenshotTestnow covers all the same stories (Timer, CoinFlip, MyFeature, SwitchFeature, App home) by rendering them through Storybook directly — which is more accurate and less maintenance burden.No behavioral change to the test suite; coverage is maintained by the Storybook-based test.
Test plan
StoryScreenshotTest🤖 Generated with Claude Code