Replace fixed bootstrap sleep with CountDownLatch#60
Open
EmilioBejasa wants to merge 4 commits intomainfrom
Open
Replace fixed bootstrap sleep with CountDownLatch#60EmilioBejasa wants to merge 4 commits intomainfrom
EmilioBejasa wants to merge 4 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Instead of sleeping a fixed 10s waiting for RN to register stories, set a CountDownLatch before launching StoryRendererActivity and await it. StorybookRegistry.registerStories() counts it down the moment JS calls in, so bootstrap returns immediately when stories are ready rather than always waiting the full timeout. Also raises the safety ceiling from 10s to 30s to give slow CI emulators enough headroom. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootstrapManifest()was doingThread.sleep(10000)— always waiting the full 10s regardless of when RN actually finished registering storiesFix
Set a
CountDownLatchonStorybookRegistrybefore launchingStoryRendererActivity.registerStories()counts it down the moment JS calls in. The test awaits the latch instead of sleeping, so bootstrap returns as soon as stories are ready — instantly on fast machines, and up to the 30s safety ceiling on slow CI emulators.Changes
StorybookRegistry: addstoriesRegisteredSignal: CountDownLatch?; callcountDown()inregisterStories()BaseStoryScreenshotTest: replaceThread.sleepwithlatch.await; raise default bootstrap timeout from 10s → 30sTest plan
🤖 Generated with Claude Code