Remove redundant screenshot-tests-for-android dependency from app#80
Open
EmilioBejasa wants to merge 9 commits intomainfrom
Open
Remove redundant screenshot-tests-for-android dependency from app#80EmilioBejasa wants to merge 9 commits intomainfrom
EmilioBejasa wants to merge 9 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…chris-workspace Had to merge code from PRs #58 and 61.
The library already exposes this via `api`, so the app doesn't need to declare it. The app's declaration also pinned the wrong version (1.0.0 vs 1.0.1 in the library). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app's
build.gradledeclaredscreenshot-tests-for-android:core:1.0.0explicitly, but the library already exposes1.0.1transitively viaapi. The redundant declaration was also pinning the wrong (older) version.Removing it means the app picks up the version from the library, keeping them in sync automatically.
Test plan
🤖 Generated with Claude Code