Skip to content

Info form#595

Open
catreedle wants to merge 5 commits intoscribe-org:mainfrom
catreedle:info-form
Open

Info form#595
catreedle wants to merge 5 commits intoscribe-org:mainfrom
catreedle:info-form

Conversation

@catreedle
Copy link
Collaborator

@catreedle catreedle commented Mar 2, 2026

Contributor checklist


Description

This PR removes old in-command state keyboard setups from Keyboard.xib and KeyboardViewController and refactor "Not in wikidata" info tooltip to use dynamic key form view.

Changes:

  • Remove unused keys elements from Keyboard.xib, its contraints and fix constraint
  • Remove unused keys elements initiation, its setup, and related functions from KeyboardViewController, change how information tooltip is shown
  • Set up showing information tooltip in DynamicConjugationViewController.swift and NavigationStructure.swift
  • Delete ToolTipViewDatasource.swift, ToolTipViewTheme.swift, ToolTipViewDatasourceable.swift, ToolTipViewUpdatable.swift, ViewThemeable.swift, ToolTipView.swift that are no longer used

Related issue

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant