Conversation
…lots on empty results
umarteauowkin
left a comment
There was a problem hiding this comment.
I approve as it is a good first draft ! In an ideal world, all the fixed kwargs should be modifiable, but in that case I think people would just recopy the code !
|
Any reason this never got merged? I'd be happy to have something like this available. |
|
I'm not sure if including plotting dependencies in pydeseq2 is the way to go (tbf, they could be optional). The scverse ecosystem offers plotting functions for differential expression via pertpy: https://pertpy.readthedocs.io/en/stable/tutorials/notebooks/differential_gene_expression.html Our vision would be to have a separate, method-agnostic package for plotting differential expression results, but this never made it past prototype stage: https://github.com/scverse/deres |
|
@grst: Fair points. However, as of now, I get MA plots from PyDESeq2 but no Volcano plots, with both of them coomonly used in the field and there is a pull-request that would add this feature in a simpel way while we all wait for the better solution. Who know, accepting this over a year ago, or at least providing this kind of feedback to the (external?) contributor that provided the PR might have motivated them to contribute more to the ecosystem and potentially even implementing this in in the context of deres. I just want to make clear that I am not complaining or trying to be pushy here. I think you all are doing a great job with scverse and I know very well how easy these kinds of things can end up low enough on everyone's priority lists to eventually never materialize. |
What does your PR implement? Be specific.
This PR implements a method in
DeseqStatsto make volcano plots.Example: