CRC tools for computation and research#4855
Open
phil777 wants to merge 1 commit intosecdev:masterfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4855 +/- ##
==========================================
- Coverage 80.88% 80.78% -0.11%
==========================================
Files 368 369 +1
Lines 90340 90607 +267
==========================================
+ Hits 73069 73194 +125
- Misses 17271 17413 +142
🚀 New features to boost your workflow:
|
Member
|
Hi ! So this is cool, but I'm a bit unsure if it has a place in Scapy. It looks to me a bit far from networking :/ What do you think? |
|
I think it’s useful for some applications, but maybe it would fit better in /modules |
Member
|
We discussed this, it could be fine in modules/, but it needs some documentation. At least docstrings :P |
Contributor
|
We discussed the place for CRC utility today. Since we need it for the implementation of CBOR, we would propose to put this utility in @phil777 What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
tox)This PR provides a CRC toolbox to compute CRC, create new ones, or search for possible CRC present in a byte string.