Enhance SuperSocket for AnsweringMachine typing#4897
Merged
polybassa merged 2 commits intosecdev:masterfrom Jan 11, 2026
Merged
Enhance SuperSocket for AnsweringMachine typing#4897polybassa merged 2 commits intosecdev:masterfrom
polybassa merged 2 commits intosecdev:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4897 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 369 369
Lines 90963 90968 +5
=======================================
+ Hits 73539 73544 +5
Misses 17424 17424
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances type annotations for the SuperSocket class to improve typing support when working with AnsweringMachine instances. The changes add proper generic typing using TypeVar and update method signatures to provide better type inference.
Changes:
- Added generic typing support with TypeVar for AnsweringMachine integration
- Enhanced the
am()method with proper type annotations using Generic types - Improved
__enter__method return type using Self for better type inference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gpotter2
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.