Draft
Conversation
|
Thanks for your pr. could you please revert all changes introduced from your code formatter. |
Author
|
@polydroi sorry for that, should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently draft, what is missing:
Introduces various stuff from Bluetooth 5.0+ plus some standardized field naming across packets for clarity and interoperability. Additionally covers an edge case in the HCI command handling.
I am currently using this code for testing actual BLE devices and """it works""". I'll add tests (and modify existing ones) asap, please advice if I may skip some tests as not everything may be necessary.
What was added:
What was modified:
r.code in (0x0e, 0x0f)to cope with commands such as "Create Connection" which is async and returns a "Pending" status.