Add value support to RIVER#874
Open
MarcMil wants to merge 4 commits intosecure-software-engineering:developfrom
Open
Add value support to RIVER#874MarcMil wants to merge 4 commits intosecure-software-engineering:developfrom
MarcMil wants to merge 4 commits intosecure-software-engineering:developfrom
Conversation
StevenArzt
requested changes
Mar 27, 2026
| import java.util.Set; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class ValueOnPath { |
Member
There was a problem hiding this comment.
We should have JavaDoc on the constraint classes to ensure that users can understand them even if they don't know the precise cases we discussed.
|
|
||
| public class ValueOnPath { | ||
|
|
||
| public static class Parameter { |
Member
There was a problem hiding this comment.
This class should have a toString implementation for easier debugging.
| * @author Steven Arzt | ||
| */ | ||
| public class SinkPropagationRule extends AbstractTaintPropagationRule { | ||
| public class SinkPropagationRule extends AbstractTaintPropagationRule implements IAdditionalFlowSinkPropagationRule { |
Member
There was a problem hiding this comment.
Please use a dedicated rule in the River package and don't hijack normal sink processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.