Skip to content

feat: ✨ use ruff to check for unused arguments instead of vulture#246

Merged
lwjohnst86 merged 1 commit intomainfrom
feat/unused-args-ruff
Feb 18, 2026
Merged

feat: ✨ use ruff to check for unused arguments instead of vulture#246
lwjohnst86 merged 1 commit intomainfrom
feat/unused-args-ruff

Conversation

@joelostblom
Copy link
Contributor

@joelostblom joelostblom commented Feb 17, 2026

Description

I haven't done any extensive comparison, but I noticed some false positives with vulture for Enum constants that ruff did not flag. It is also more convenient that this is marked up by ruff in the editor instead of just when running the justfile.

Closes #241
Needs a quick review.

Checklist

  • Ran just run-all

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cooolll

@github-project-automation github-project-automation bot moved this from In Review to Approved in Iteration planning Feb 18, 2026
@lwjohnst86 lwjohnst86 merged commit 12941f3 into main Feb 18, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Iteration planning Feb 18, 2026
@lwjohnst86 lwjohnst86 deleted the feat/unused-args-ruff branch February 18, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Replace vulture's unused variable and unused import checks with ruff?

2 participants

Comments