fix: pruning goroutine lifecycle management to prevent nil pointer on Close#2800
Open
blindchaser wants to merge 3 commits intomainfrom
Open
fix: pruning goroutine lifecycle management to prevent nil pointer on Close#2800blindchaser wants to merge 3 commits intomainfrom
blindchaser wants to merge 3 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2800 +/- ##
===========================================
+ Coverage 48.37% 57.25% +8.87%
===========================================
Files 671 2099 +1428
Lines 50621 172437 +121816
===========================================
+ Hits 24486 98721 +74235
- Misses 23987 64865 +40878
- Partials 2148 8851 +6703
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| default: | ||
| } | ||
|
|
||
| pruneStartTime := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| } | ||
| m.startOnce.Do(func() { | ||
| m.wg.Add(1) | ||
| go m.pruneLoop() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| time.Sleep(time.Duration(m.pruneInterval+randomDelay) * time.Second) | ||
| // Generate a random percentage (between 0% and 100%) of the fixed interval as a delay | ||
| randomPercentage := rand.Float64() | ||
| randomDelay := int64(float64(m.pruneInterval) * randomPercentage) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
blindchaser
force-pushed
the
yiren/fix-prune
branch
3 times, most recently
from
b1ef012 to
9dba675
Compare
… Close - Add proper Stop() with stopCh/WaitGroup to pruning Manager for graceful shutdown - Save pruning manager in CompositeStateStore and stop it on Close (idempotent) - Add defensive nil checks in pebbledb/rocksdb Prune() for closed databases - Remove duplicate stateStore.Close() in app HandleClose (already closed by BaseApp) Co-authored-by: Cursor <cursoragent@cursor.com>
blindchaser
force-pushed
the
yiren/fix-prune
branch
from
9dba675 to
c4fa85d
Compare
Previously, pruneSnapshots() was only called after a successful snapshot rewrite. If snapshot creation kept failing, old snapshots would accumulate indefinitely. Now we prune old snapshots regardless of rewrite outcome. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change