fix: prevent nil pointer panic during pruning on shutdown#2801
Closed
blindchaser wants to merge 4 commits intorelease/v6.3from
Closed
fix: prevent nil pointer panic during pruning on shutdown#2801blindchaser wants to merge 4 commits intorelease/v6.3from
blindchaser wants to merge 4 commits intorelease/v6.3from
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (38.27%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2801 +/- ##
================================================
- Coverage 43.36% 42.13% -1.23%
================================================
Files 1866 1465 -401
Lines 155305 114756 -40549
================================================
- Hits 67351 48356 -18995
+ Misses 81941 62285 -19656
+ Partials 6013 4115 -1898
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kbhat1
approved these changes
Feb 4, 2026
539fec2 to
d9c1599
Compare
yzang2019
approved these changes
Feb 4, 2026
masih
approved these changes
Feb 4, 2026
masih
reviewed
Feb 4, 2026
sei-db/ss/pebbledb/db.go
Outdated
|
|
||
| func (db *Database) Close() error { | ||
| // Mark as closed first to signal pruning to skip/return early | ||
| db.closed.Store(true) |
Collaborator
There was a problem hiding this comment.
This should do a compare and swap and proceed if not closed already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change