[giga] add mixed mode integration test and fixes for app hash#2831
Open
stevenlanders wants to merge 6 commits intomainfrom
Open
[giga] add mixed mode integration test and fixes for app hash#2831stevenlanders wants to merge 6 commits intomainfrom
stevenlanders wants to merge 6 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
===========================================
+ Coverage 46.23% 56.77% +10.53%
===========================================
Files 2005 2070 +65
Lines 163000 168308 +5308
===========================================
+ Hits 75366 95557 +20191
+ Misses 81111 64263 -16848
- Partials 6523 8488 +1965
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giga Executor: Fix AppHash Divergence & Add Mixed-Mode Integration Tests
For failed executor txs, Giga was missing:
Nonce increment — V2 bumps it even on failure
Finalize() — commits the fee SubBalance to store
Surplus tracking — tells EndBlock to credit EVM module account
GasWanted field — included in LastResultsHash computation