fix(giga): return all balances in bank keeper#2832
Closed
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 56.77% 52.74% -4.04%
==========================================
Files 2070 1067 -1003
Lines 168281 87069 -81212
==========================================
- Hits 95545 45922 -49623
+ Misses 64252 36811 -27441
+ Partials 8484 4336 -4148
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
codchen
approved these changes
Feb 11, 2026
arajasek
added a commit
that referenced
this pull request
Feb 12, 2026
## Describe your changes and provide context Three commits: - `fix(giga): perform initial fee validation`: ported from #2782, with lint fixed - `fix(giga): return all balances in bank keeper`: ported from #2832 - `fix(giga): increase nonce even in early-exit case`: fixes the apphash mismatch caused by [this transaction](https://seiscan.io/tx/0x9bb68ac3a7ce771cd5234bd962706fc1046f589262298a9eae74540a36173f09) ## Testing performed to validate your change
Contributor
Author
|
Landed as part of #2862, which will land in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
this matches the behaviour in the v2 keeper, and fixes the mismatch in this block. Slack discussion here.
Testing performed to validate your change
Apphash mismatch fixed.