perf(store): hybrid sync.Map + RWMutex in multiversion Store#2836
Merged
pdrobnjak merged 1 commit intoperf/lazy-cachemultistorefrom Feb 11, 2026
Merged
perf(store): hybrid sync.Map + RWMutex in multiversion Store#2836pdrobnjak merged 1 commit intoperf/lazy-cachemultistorefrom
pdrobnjak merged 1 commit intoperf/lazy-cachemultistorefrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## perf/lazy-cachemultistore #2836 +/- ##
==============================================================
- Coverage 56.78% 46.26% -10.52%
==============================================================
Files 2070 2005 -65
Lines 168339 163080 -5259
==============================================================
- Hits 95586 75445 -20141
- Misses 64262 81114 +16852
+ Partials 8491 6521 -1970
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+205
to
+207
| for index, keys := range s.txWritesetKeys { | ||
| writesetKeys[index] = keys | ||
| return true | ||
| }) | ||
|
|
||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Keep sync.Map for multiVersionMap (lock-free reads essential for OCC workers) while replacing sync.Map with plain map + RWMutex for the three per-tx-index maps (txWritesetKeys, txReadSets, txIterateSets) where contention is low (each worker writes to its own index slot). Eliminates HashTrieMap allocations from per-tx-index maps while preserving lock-free read performance for the hot multiVersionMap path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
force-pushed
the
perf/hybrid-syncmap-rwmutex
branch
from
2b3cec4 to
f8b8fc9
Compare
pdrobnjak
force-pushed
the
perf/replace-syncmap-cachekv
branch
from
6ab07c6 to
bb5063e
Compare
Base automatically changed from
perf/replace-syncmap-cachekv
to
perf/lazy-cachemultistore
February 11, 2026 13:19
Contributor
Author
|
This PR was auto-merged by GitHub during a stack reorder (branch force-push made head appear merged into base). No code was actually merged to main. This PR has been superseded — see the restacked PR chain starting at #2849. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.Mapwith a hybridsync.Map+RWMutexapproach in the multiversion store for better read/write performanceStack
1/13 — base of the perf stack
🤖 Generated with Claude Code