Skip to content

Return proper error message when SS disabled#2911

Open
yzang2019 wants to merge 7 commits intomainfrom
yzang/return-error-msg
Open

Return proper error message when SS disabled#2911
yzang2019 wants to merge 7 commits intomainfrom
yzang/return-error-msg

Conversation

@yzang2019
Copy link
Contributor

Describe your changes and provide context

Currently if SS is disabled and one tries to query historical state, you'll get error like:

Error: rpc error: code = Unknown desc = kv store with key KVStoreKey{0xc000c88020, acc} has not been registered in stores: panic

However, it is not explicit and we should return the correct error message to indicate this was due to misconfiguration.

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 18, 2026, 3:45 AM

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.30%. Comparing base (07025b9) to head (1696b53).

❗ There is a different number of reports uploaded between BASE (07025b9) and HEAD (1696b53). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (07025b9) HEAD (1696b53)
sei-chain 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2911       +/-   ##
===========================================
- Coverage   57.22%   48.30%    -8.92%     
===========================================
  Files        2094      671     -1423     
  Lines      171956    50626   -121330     
===========================================
- Hits        98400    24456    -73944     
+ Misses      64739    23988    -40751     
+ Partials     8817     2182     -6635     
Flag Coverage Δ
sei-chain ?
sei-cosmos 48.12% <100.00%> (-0.08%) ⬇️
sei-db 68.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/storev2/rootmulti/store.go 31.87% <100.00%> (-9.98%) ⬇️

... and 1554 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* main:
  feat(sei-db): add flatkv store implementation (#2793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants