Draft
Conversation
Add TypeScript type definitions for: - Snapshot union type (FreezeFrameSnapshot | RosbagSnapshot) - EnvironmentData with extended_data_records and snapshots - FaultResponse with item wrapper and SOVD status object - BulkDataDescriptor for listing rosbags - Type guards: isFreezeFrameSnapshot, isRosbagSnapshot Add unit tests for type guards and structure validation.
Update API client: - getFaultWithEnvironmentData() returns FaultResponse with environment_data - Add listBulkDataCategories() for category listing - Add listBulkData() for descriptor listing - Add getBulkDataUrl() for building download URLs - Add downloadBulkData() for fetching files as blobs - Add formatBytes() and formatDuration() utilities - Mark legacy getFaultSnapshots() as deprecated Add comprehensive unit tests with mocked fetch.
Add components for fault environment data visualization: - RosbagDownloadButton: Download button with size display and tooltip - SnapshotCard: Card component for freeze frame and rosbag snapshots - FaultsPanel: Updated to fetch and display environment_data - Collapsible fault cards with lazy loading - Extended data records display (first/last occurrence) - Snapshot list with inline download capability - Add TooltipProvider to App for tooltip support - Add shadcn tooltip component Add unit tests for RosbagDownloadButton and SnapshotCard.
Align TypeScript types and component property access with the corrected ROS 2 message field names (first_occurrence_ns, last_occurrence_ns). Updates FaultsPanel and test fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Briefly describe what changed and why.
Issue
Link the related issue (required):
Type
Testing
How was this tested / how should reviewers verify it?
Checklist
npm run lint)npm run build)