Skip to content

feat: make conventionalcommits default preset#858

Open
babblebey wants to merge 10 commits intomasterfrom
feat/default-preset
Open

feat: make conventionalcommits default preset#858
babblebey wants to merge 10 commits intomasterfrom
feat/default-preset

Conversation

@babblebey
Copy link
Copy Markdown
Member

@babblebey babblebey commented Mar 6, 2026

This pull request updates the default commit message parsing preset from angular to conventionalcommits, aligning the project with the Conventional Commits specification.

Changes Made

  • Updated the implementation in lib/load-parser-config.js to use conventional-changelog-conventionalcommits as the default preset instead of conventional-changelog-angular. [1] [2]
  • Replaced conventional-changelog-angular with conventional-changelog-conventionalcommits in runtime dependencies in package.json.
  • Updated integration and unit tests to expect conventionalcommits as the default preset instead of angular, ensuring test coverage matches the new behavior. [1] [2]
  • Changed the default preset in the README.md documentation from angular to conventionalcommits, clarifying expected behavior for users.

Related Issue

Fixes semantic-release/semantic-release#3406
Fixes #231
Fixes #759
Closes semantic-release/semantic-release#1836
Closes semantic-release/semantic-release#1652

@babblebey babblebey marked this pull request as ready for review March 9, 2026 04:05
@babblebey babblebey requested a review from travi March 9, 2026 04:15
@travi
Copy link
Copy Markdown
Member

travi commented Mar 27, 2026

i'm excited to move this forward, but there are other pieces to this effort that we will need to coordinate, like the release-notes-generator. also, the conflict with commitlint seems to be ongoing, so i'm hesitant to switch our default if that is going to result in problems for folks using that in addition to semantic-release (which we do recommend using together). if we do move this forward with coordination across our other package(s), we need to make sure that is handled somehow.

@babblebey
Copy link
Copy Markdown
Member Author

I'll look into the part that needs to be coordinated fir sure.

switch our default if that is going to result in problems for folks using that in addition to semantic-release (which we do recommend using together)

How'd you mean we do not recommend though???

It is true we might have to switch defaults too on semantic-release though, but I believe that just happens on upgrade to the version we release from this change, right!?

@travi
Copy link
Copy Markdown
Member

travi commented Mar 27, 2026

How'd you mean we do not recommend though???

we do recommend using with commitlint. however, folks that have been using semantic-release and commitlint, and installing locally, have been running into problems with conflicting versions of the underlying conventional-changelog package.

I believe that just happens on upgrade to the version we release from this change, right!?

right, once we update core to depend on these new major versions, these changes will be realized there. i'm just not confident that there wont also be some changes needed in core without investigating further. i think this change will be disruptive enough that we will want to release as a prerelease across the impacted packages before promoting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants