Skip to content

Move custom schema documentation to pipeline-schema overview#1139

Open
llewellyn-sl wants to merge 10 commits intomasterfrom
plat-4015-custom-schema-docs-update
Open

Move custom schema documentation to pipeline-schema overview#1139
llewellyn-sl wants to merge 10 commits intomasterfrom
plat-4015-custom-schema-docs-update

Conversation

@llewellyn-sl
Copy link
Contributor

Summary

  • Moved custom schema section from pipelines/versioning.md to pipeline-schema/overview.md
  • Renamed section to "Define pipeline schema"
  • Added documentation for all three schema options:
    • Repository default
    • Repository path
    • Seqera Platform schema
  • Added note about unique schema id field requirement
  • Updated cross-references in versioning.md
  • Applied changes to both Cloud and Enterprise v25.3 docs

Test plan

  • Verify new section appears correctly in pipeline-schema/overview.md for Cloud and Enterprise v25.3
  • Verify Custom schema section removed from versioning.md for Cloud and Enterprise v25.3
  • Verify cross-reference links work correctly
  • Review rendered documentation in deploy preview

🤖 Generated with Claude Code

llewellyn-sl and others added 5 commits December 12, 2025 13:18
Updates pipeline versioning documentation with GA release features:
- Add nested parameter support for track_changes at leaf node level
- Update terminology from "checksum" to "hash" throughout
- Add versionName and versionHash search keywords
- Document shared pipeline publishing restrictions
- Add pipeline optimization integration section

Related to PLAT-4471 (Versioning GA QA Testing)
- PLAT-3576: Version search with additional keywords
- PLAT-4051: Version hash terminology update
- PLAT-3877: Nested schema property support
- PLAT-3501: Pipeline optimization integration
- PLAT-4090: Shared pipeline publishing behavior

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…nges

- Add custom schema documentation to Cloud and Enterprise 25.3 versioning pages
- Remove preview status from Enterprise 25.3 (feature now GA)
- Add commit ID pinning recommendation for Enterprise 25.3
- Update shared pipeline editing notes to clarify workspace restrictions
- Update pipeline optimization section for non-default version clarity
- Remove versioning page from Cloud sidebar (releasing Feb 19)

Addresses PR review comments from PLAT-3570 custom schema feature.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add "Define pipeline schema" section to pipeline-schema/overview.md
- Document all three schema options: Repository default, Repository path, and Seqera Platform schema
- Include detailed instructions for Seqera Platform schema option
- Add note about unique schema id field requirement
- Remove Custom schema section from pipelines/versioning.md
- Update versioning.md references to point to new location
- Apply changes to both Cloud and Enterprise v25.3 docs

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 7cf188f
🔍 Latest deploy log https://app.netlify.com/projects/seqera-docs/deploys/699dcf653761720008ddc39a
😎 Deploy Preview https://deploy-preview-1139--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@llewellyn-sl
Copy link
Contributor Author

@claude please review

@claude
Copy link

claude bot commented Feb 17, 2026

Claude finished @llewellyn-sl's task —— View job


Reviewing PR: Move custom schema documentation

  • Read CLAUDE.md for repository guidelines (none found)
  • Review documentation restructuring changes
  • Check custom schema content migration
  • Verify cross-reference links
  • Review sidebar navigation updates
  • Provide comprehensive feedback

Review Summary

This PR successfully restructures the custom schema documentation with good improvements. The changes are well-executed and improve the organization of the documentation.

✅ Positive Changes

  1. Better logical placement: Moving custom schema docs from versioning.md to pipeline-schema/overview.md creates better topical cohesion
  2. Enhanced content: The new section provides more comprehensive coverage of all three schema options (Repository default, Repository path, Seqera Platform schema)
  3. Improved terminology: "Seqera Platform schema" is clearer than the previous "Custom schema"
  4. Proper cross-referencing: Updated link in versioning.md:45 correctly points to the new location
  5. Consistent application: Changes applied to both Cloud and Enterprise v25.3 documentation

🔍 Minor Issues Found

platform-cloud/docs/pipelines/versioning.md:8-12

  • Missing tip callout about commit ID pinning that exists in Enterprise version
  • Enterprise version has a better tip about deterministic execution with commit ID pinning

Content consistency

  • Both versions should have the same introductory content for consistency

📝 Documentation Quality

The migrated content maintains high quality:

  • Clear step-by-step instructions for Platform schema setup
  • Important note about unique id field requirement
  • Proper formatting and structure
  • Good use of bullet points for feature lists

🔗 Cross-References Status

  • versioning.md:45 correctly updated to point to new location
  • ✅ Link structure follows proper relative path format
  • ✅ Fragment identifier #define-pipeline-schema matches new section header

Overall Assessment

This is a well-executed documentation restructuring that improves content organization and adds valuable detail. The changes enhance user experience by consolidating schema-related information in the appropriate location.

Recommendation: ✅ Approved - Consider adding the missing tip callout to Cloud versioning.md for consistency with Enterprise version.

Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
@llewellyn-sl
Copy link
Contributor Author

@claude I resolved conflicts, that should take care of the missing tip you highlighted in your previous review. Please review again

@claude
Copy link

claude bot commented Feb 17, 2026

Claude finished @llewellyn-sl's task —— View job


Re-reviewing PR after conflict resolution

  • Read updated changed files
  • Compare with previous review findings about missing tip
  • Check content consistency between Cloud and Enterprise versions
  • Verify cross-reference links still work
  • Provide updated comprehensive review feedback

✅ Issues Resolved

Great work! The conflict resolution has successfully addressed the content inconsistency issue I identified in my previous review:

Cloud vs Enterprise versioning.md consistency:

  • Cloud version now includes the missing tip callout (lines 10-12): The preview feature info callout is now present, providing important context about pipeline versioning being a preview feature
  • Content alignment: Both versions now have appropriate introductory content, though slightly different due to the preview status difference

✅ Continued Strengths

All the positive aspects from my previous review remain intact:

  1. Excellent content migration: Custom schema documentation successfully moved from versioning.md to pipeline-schema/overview.md
  2. Enhanced documentation: The new "Define pipeline schema" section (lines 14-43 in both overview.md files) provides comprehensive coverage of all three schema options
  3. Improved terminology: "Seqera Platform schema" is much clearer than the previous "Custom schema"
  4. Perfect cross-referencing: Links in versioning.md:45 (Cloud) and versioning.md:46 (Enterprise) correctly point to the new location
  5. Consistent application: Changes properly applied across both Cloud and Enterprise v25.3 documentation

🔍 Current State Analysis

Cross-reference verification:

  • versioning.md:45../pipeline-schema/overview.md#define-pipeline-schema (working)
  • versioning.md:46../pipeline-schema/overview.md#define-pipeline-schema (working)
  • ✅ Fragment identifier matches the new section header exactly

Content quality:

  • ✅ Clear step-by-step instructions for Platform schema setup
  • ✅ Important note about unique id field requirement (overview.md:41-43)
  • ✅ Proper formatting and structure maintained
  • ✅ Good use of callouts and bullet points

Final Assessment

Recommendation: ✅ Approved - All previous issues have been resolved. The conflict resolution successfully addressed the content inconsistency, and the PR now provides a clean, well-structured documentation improvement that enhances user experience by consolidating schema-related information in the logical location.

The documentation restructuring is complete and ready for merge.


llewellyn-sl and others added 3 commits February 18, 2026 13:17
Updates versioning documentation to clarify that resource labels are excluded
from triggering new pipeline versions, alongside name, image, description, and labels.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Rename "Custom schema" to "Seqera Platform schema" in versioning.md
- Trim duplicate content in versioning.md and link to pipeline-schema overview
- Update id field note to mention removal as a valid fix
- Add full stops to list items in pipeline-schema overview

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Copy link
Contributor

@swingingsimian swingingsimian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes I think but LGTM


#### Seqera Platform schema

Users with [Maintain or higher](../orgs-and-teams/roles.md) permissions can upload a custom `nextflow_schema.json` file directly to Seqera Platform. When you upload a Platform schema:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is actually no name and we're not uploading files for the custom schemas at present, so nextflow_schema.json is not quite right. We can just reference it as plain text as we have else where i.e.

..upload a custom Nextflow JSON schema directly to...


- The schema content is validated to ensure it's a valid JSON schema.
- The Platform schema controls which parameters appear in the pipeline launch form.
- Changes to the Platform schema trigger a new draft version of the pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR; I think we can remove this line re triggering a version.

Versioning isn't actually GA in cloud yet, although will be shortly. Regardless, I think the fact changes trigger a version sit better in the versioning docs. We don't reference what triggers a version across the rest of the pipeline docs, barring the versioning doc itself. That's also where we explain why schemas are important wrt versioning i.e. track_changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants