Move custom schema documentation to pipeline-schema overview#1139
Move custom schema documentation to pipeline-schema overview#1139llewellyn-sl wants to merge 10 commits intomasterfrom
Conversation
Updates pipeline versioning documentation with GA release features: - Add nested parameter support for track_changes at leaf node level - Update terminology from "checksum" to "hash" throughout - Add versionName and versionHash search keywords - Document shared pipeline publishing restrictions - Add pipeline optimization integration section Related to PLAT-4471 (Versioning GA QA Testing) - PLAT-3576: Version search with additional keywords - PLAT-4051: Version hash terminology update - PLAT-3877: Nested schema property support - PLAT-3501: Pipeline optimization integration - PLAT-4090: Shared pipeline publishing behavior Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…nges - Add custom schema documentation to Cloud and Enterprise 25.3 versioning pages - Remove preview status from Enterprise 25.3 (feature now GA) - Add commit ID pinning recommendation for Enterprise 25.3 - Update shared pipeline editing notes to clarify workspace restrictions - Update pipeline optimization section for non-default version clarity - Remove versioning page from Cloud sidebar (releasing Feb 19) Addresses PR review comments from PLAT-3570 custom schema feature. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add "Define pipeline schema" section to pipeline-schema/overview.md - Document all three schema options: Repository default, Repository path, and Seqera Platform schema - Include detailed instructions for Seqera Platform schema option - Add note about unique schema id field requirement - Remove Custom schema section from pipelines/versioning.md - Update versioning.md references to point to new location - Apply changes to both Cloud and Enterprise v25.3 docs Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@claude please review |
|
Claude finished @llewellyn-sl's task —— View job Reviewing PR: Move custom schema documentation
Review SummaryThis PR successfully restructures the custom schema documentation with good improvements. The changes are well-executed and improve the organization of the documentation. ✅ Positive Changes
🔍 Minor Issues Foundplatform-cloud/docs/pipelines/versioning.md:8-12
Content consistency
📝 Documentation QualityThe migrated content maintains high quality:
🔗 Cross-References Status
Overall AssessmentThis is a well-executed documentation restructuring that improves content organization and adds valuable detail. The changes enhance user experience by consolidating schema-related information in the appropriate location. Recommendation: ✅ Approved - Consider adding the missing tip callout to Cloud versioning.md for consistency with Enterprise version. |
Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
|
@claude I resolved conflicts, that should take care of the missing tip you highlighted in your previous review. Please review again |
|
Claude finished @llewellyn-sl's task —— View job Re-reviewing PR after conflict resolution
✅ Issues ResolvedGreat work! The conflict resolution has successfully addressed the content inconsistency issue I identified in my previous review: Cloud vs Enterprise versioning.md consistency:
✅ Continued StrengthsAll the positive aspects from my previous review remain intact:
🔍 Current State AnalysisCross-reference verification:
Content quality:
Final AssessmentRecommendation: ✅ Approved - All previous issues have been resolved. The conflict resolution successfully addressed the content inconsistency, and the PR now provides a clean, well-structured documentation improvement that enhances user experience by consolidating schema-related information in the logical location. The documentation restructuring is complete and ready for merge. |
Updates versioning documentation to clarify that resource labels are excluded from triggering new pipeline versions, alongside name, image, description, and labels. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
platform-enterprise_versioned_docs/version-25.3/pipelines/versioning.md
Outdated
Show resolved
Hide resolved
platform-enterprise_versioned_docs/version-25.3/pipeline-schema/overview.md
Show resolved
Hide resolved
platform-enterprise_versioned_docs/version-25.3/pipeline-schema/overview.md
Outdated
Show resolved
Hide resolved
- Rename "Custom schema" to "Seqera Platform schema" in versioning.md - Trim duplicate content in versioning.md and link to pipeline-schema overview - Update id field note to mention removal as a valid fix - Add full stops to list items in pipeline-schema overview Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
swingingsimian
left a comment
There was a problem hiding this comment.
A few minor changes I think but LGTM
|
|
||
| #### Seqera Platform schema | ||
|
|
||
| Users with [Maintain or higher](../orgs-and-teams/roles.md) permissions can upload a custom `nextflow_schema.json` file directly to Seqera Platform. When you upload a Platform schema: |
There was a problem hiding this comment.
The is actually no name and we're not uploading files for the custom schemas at present, so nextflow_schema.json is not quite right. We can just reference it as plain text as we have else where i.e.
..upload a custom Nextflow JSON schema directly to...
|
|
||
| - The schema content is validated to ensure it's a valid JSON schema. | ||
| - The Platform schema controls which parameters appear in the pipeline launch form. | ||
| - Changes to the Platform schema trigger a new draft version of the pipeline. |
There was a problem hiding this comment.
TLDR; I think we can remove this line re triggering a version.
Versioning isn't actually GA in cloud yet, although will be shortly. Regardless, I think the fact changes trigger a version sit better in the versioning docs. We don't reference what triggers a version across the rest of the pipeline docs, barring the versioning doc itself. That's also where we explain why schemas are important wrt versioning i.e. track_changes.
Summary
pipelines/versioning.mdtopipeline-schema/overview.mdidfield requirementTest plan
🤖 Generated with Claude Code