Skip to content

Inline utf-8 crate#731

Merged
nicoburns merged 1 commit intoservo:mainfrom
nicoburns:inline-utf8
Feb 26, 2026
Merged

Inline utf-8 crate#731
nicoburns merged 1 commit intoservo:mainfrom
nicoburns:inline-utf8

Conversation

@nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Feb 26, 2026

Vendors the small portion of the utf-8 crate that we use and then removes the dependency.

Signed-off-by: Nico Burns <nico@nicoburns.com>
@nicoburns nicoburns added dependencies Pull requests that update a dependency file V-non-breaking A non-breaking change labels Feb 26, 2026
Copy link
Contributor

@simonwuelker simonwuelker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

tendril actually defines a wrapper around utf8::Incomplete which becomes sort of unnecessary when we vendor utf8. I have a patch for that ready for merging the two together, so I'll submit that as a followup.

@nicoburns
Copy link
Contributor Author

I have a patch for that ready for merging the two together, so I'll submit that as a followup.

Sounds great! I think there's quite a lot of just "general Rust code improvements" possible in tendril. But I figured it was better split "inline the existing" and "improving the code" into seperate PRs.

@nicoburns nicoburns added this pull request to the merge queue Feb 26, 2026
Merged via the queue into servo:main with commit 13135ed Feb 26, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file V-non-breaking A non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using the utf-8 crate

2 participants