Skip to content

refactor: migrate from nodes-sdk-alpha to raw fetch calls#261

Merged
sigmachirality merged 7 commits intomainfrom
shantanu/ts-cli-fix-image-show
Apr 14, 2026
Merged

refactor: migrate from nodes-sdk-alpha to raw fetch calls#261
sigmachirality merged 7 commits intomainfrom
shantanu/ts-cli-fix-image-show

Conversation

@joshi4
Copy link
Copy Markdown
Contributor

@joshi4 joshi4 commented Apr 13, 2026

fix: sf nodes image show hits the correct v2 api

refactor(image/show): migrate from nodes-sdk-alpha to apiClient
fix(image/show): use correct download.url field from API response
fix(images/get): use correct download.url field from API response

Amp-Thread-ID: https://ampcode.com/threads/T-019d87dd-dad2-7700-a643-f114d525cd0a
Co-authored-by: Amp amp@ampcode.com

Copy link
Copy Markdown
Contributor Author

joshi4 commented Apr 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com bot commented Apr 13, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib/nodes/image/show.tsx  48% smaller
  src/lib/images/get.tsx  34% smaller
  src/lib/contracts/ContractDisplay.tsx  29% smaller
  src/schema.ts  0% smaller

Copy link
Copy Markdown
Contributor Author

joshi4 commented Apr 13, 2026

image url is now shown

image.png

sf nodes image show now works.

image.png

@joshi4 joshi4 requested a review from 0xJepsen April 13, 2026 17:49
Comment thread src/lib/nodes/image/show.tsx Outdated
@sigmachirality sigmachirality changed the title refactor(image/show): migrate from nodes-sdk-alpha to apiClient refactor: migrate from nodes-sdk-alpha to apiClient Apr 14, 2026
@sigmachirality sigmachirality changed the title refactor: migrate from nodes-sdk-alpha to apiClient refactor: migrate from nodes-sdk-alpha to raw fetch calls Apr 14, 2026
@sigmachirality sigmachirality merged commit 08a40ef into main Apr 14, 2026
3 checks passed
@sigmachirality sigmachirality deleted the shantanu/ts-cli-fix-image-show branch April 14, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants