Skip to content

Fix CI and other issues#1339

Open
Billyzhang1229 wants to merge 9 commits intosgkit-dev:mainfrom
Billyzhang1229:ao-dev
Open

Fix CI and other issues#1339
Billyzhang1229 wants to merge 9 commits intosgkit-dev:mainfrom
Billyzhang1229:ao-dev

Conversation

@Billyzhang1229
Copy link

@Billyzhang1229 Billyzhang1229 commented Feb 3, 2026

  • Pin pandas <3.0 in requirements and pyproject (Dask/pandas 3.0 not fully supported yet)
  • Split NumPy constraints by sys_platform (Apple ARM uses NumPy >=2.3.5)
  • Drop Python 3.10 and NumPy 1.x support (requirements + CI workflows + docs)
  • Make xr.concat data_vars explicit to silence FutureWarning
  • Expand Zarr error regex to accept “contains data”
  • Ignore .hypothesis in pytest collection
  • Filter known runtime warnings (Numba correlation_reduce_cpu, Zarr v3 dtype warning)
  • Fix Windows CI: conda only for msprime, pip for requirements (PEP 508 markers)
  • Docs: update xarray intersphinx link and use PEP 604 unions to avoid typing.Union nitpicks
  • Temporary disable notebook execution due to missing link
  • Update mergify Python targets

#1338

* Pin pandas <3.0 in requirements and pyproject
* Split NumPy constraints by Python version for Apple M4 error
* Make xr.concat data_vars explicit to silence FutureWarning
* Expand zarr error regex to accept "contains data"
* Ignore .hypothesis in pytest collection
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM - thanks @Billyzhang1229!

@Billyzhang1229 Billyzhang1229 force-pushed the ao-dev branch 3 times, most recently from 923fefb to 27d6a19 Compare February 4, 2026 22:10
@jeromekelleher
Copy link
Member

We could also consider dropping Mergify - the built in GitHub support has been working well over in tskit-dev.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Billyzhang1229
Copy link
Author

The only failing job is the Cubed workflow.

The Cubed workflow explicitly installs dev builds from GitHub, overriding the pinned dependencies in requirements.txt. In .github/workflows/cubed.yml it runs:

python -m pip install -U git+https://github.com/cubed-dev/cubed.git -U git+https://github.com/cubed-dev/cubed-xarray.git -U git+https://github.com/pydata/xarray.git

The Cubed failure is due to an upstream FutureWarning / behavior change related to tuple-based chunk specification in xarray 2026.1.1.dev18.

@tomwhite
Copy link
Member

tomwhite commented Feb 6, 2026

The only failing job is the Cubed workflow.

It would be OK to skip this until we can fix it.

@Billyzhang1229
Copy link
Author

Cool, I’ll go ahead and squash the commits.

@jeromekelleher
Copy link
Member

These commits all seem like they do something well specified, so no need to squash from my perspective

@Billyzhang1229
Copy link
Author

There are a couple of small dev commits (15c21ad, 27d6a19) where I iterated on the same change. I’ll tidy those up / revert the redundant bits to keep the history clean, but otherwise I’ll leave the commits as-is rather than squashing.

@Billyzhang1229
Copy link
Author

I’ve tidied things up a bit now. removed the dev commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants