Skip to content

expiry(1): Remove program#1481

Merged
ikerexxe merged 1 commit intoshadow-maint:masterfrom
alejandro-colomar:expir
Feb 23, 2026
Merged

expiry(1): Remove program#1481
ikerexxe merged 1 commit intoshadow-maint:masterfrom
alejandro-colomar:expir

Conversation

@alejandro-colomar
Copy link
Copy Markdown
Collaborator

@alejandro-colomar alejandro-colomar commented Jan 6, 2026

Password expiration is deprecated, and will be eventually removed.

The functionality of expiry(1) is the most superfluous of password expiry and can be removed early. This shouldn't conflict with any existing regulations about password expiry.

Link: #1432


Revisions:

v1b
  • Rebase
$ git rd 
1:  36e6669ea3ed ! 1:  f091bad9eab8 */: expiry(1): Remove program
    @@ src/Makefile.am: noinst_PROGRAMS = sulogin
      suidbins      += su
      endif
     @@ src/Makefile.am: chfn_LDADD     = $(LDADD) $(LIBPAM) $(LIBAUDIT) $(LIBSELINUX) $(LIBCRYPT_NOPAM)
    - chgpasswd_LDADD = $(LDADD) $(LIBPAM_SUID) $(LIBAUDIT) $(LIBSELINUX) $(LIBCRYPT) $(LIBECONF)
    + chgpasswd_LDADD = $(LDADD) $(LIBAUDIT) $(LIBSELINUX) $(LIBCRYPT) $(LIBECONF)
      chsh_LDADD     = $(LDADD) $(LIBPAM) $(LIBAUDIT) $(LIBSELINUX) $(LIBCRYPT_NOPAM) $(LIBSKEY) $(LIBMD) $(LIBECONF)
      chpasswd_LDADD = $(LDADD) $(LIBPAM) $(LIBAUDIT) $(LIBSELINUX) $(LIBCRYPT) $(LIBECONF) -ldl
     -expiry_LDADD = $(LDADD) $(LIBECONF)
      gpasswd_LDADD  = $(LDADD) $(LIBAUDIT) $(LIBSELINUX) $(LIBCRYPT) $(LIBECONF)
    - groupadd_LDADD = $(LDADD) $(LIBPAM_SUID) $(LIBAUDIT) $(LIBSELINUX) $(LIBECONF) -ldl
    - groupdel_LDADD = $(LDADD) $(LIBPAM_SUID) $(LIBAUDIT) $(LIBSELINUX) $(LIBECONF) -ldl
    + groupadd_LDADD = $(LDADD) $(LIBAUDIT) $(LIBSELINUX) $(LIBECONF) -ldl
    + groupdel_LDADD = $(LDADD) $(LIBAUDIT) $(LIBSELINUX) $(LIBECONF) -ldl
     
      ## src/expiry.c (deleted) ##
     @@

@alejandro-colomar alejandro-colomar self-assigned this Jan 6, 2026
@alejandro-colomar alejandro-colomar marked this pull request as ready for review January 6, 2026 17:20
@alejandro-colomar alejandro-colomar changed the title *: expiry(1): Remove program */: expiry(1): Remove program Jan 6, 2026
@alejandro-colomar alejandro-colomar changed the title */: expiry(1): Remove program expiry(1): Remove program Jan 6, 2026
@ikerexxe
Copy link
Copy Markdown
Collaborator

From my perspective as both a project and Fedora maintainer, this looks good because it reduces the amount of code we maintain without losing functionality, given that chage already offers the same thing. But I am concerned that this tool is being used in several distributions such as Debian, Alpine, and openSUSE. It would be interesting to CC their maintainers so that they are aware of this change.

@alejandro-colomar
Copy link
Copy Markdown
Collaborator Author

Cc: @zeha, @thesamesam , @jubalh , @floppym

@floppym
Copy link
Copy Markdown
Contributor

floppym commented Jan 13, 2026

I have no objection to this.

@alejandro-colomar
Copy link
Copy Markdown
Collaborator Author

From my perspective as both a project and Fedora maintainer, this looks good because it reduces the amount of code we maintain without losing functionality, given that chage already offers the same thing. But I am concerned that this tool is being used in several distributions such as Debian, Alpine, and openSUSE. It would be interesting to CC their maintainers so that they are aware of this change.

Gentoo (@floppym ) and Fedora (you, @ikerexxe ) expressed approval, and the others remained silent for more than a month, which I interpret as not being too bothered by it.

Should we merge now?

Password expiration is deprecated, and will be eventually removed.

The functionality of expiry(1) is the most superfluous of password
expiry and can be removed early.  This shouldn't conflict with any
existing regulations about password expiry.

Link: <shadow-maint#1432>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Copy link
Copy Markdown
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since nobody objected let's merge it

@ikerexxe ikerexxe merged commit 2bb1b98 into shadow-maint:master Feb 23, 2026
12 checks passed
@alejandro-colomar alejandro-colomar deleted the expir branch February 23, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants