Skip to content

lib/nss.c: Verify that lines are complete #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alejandro-colomar wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −3
Open

lib/nss.c: Verify that lines are complete #1563

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e6087a
lib/nss.c: Fix incorrect handling of white space
alejandro-colomar Mar 3, 2026
0528c3c
lib/nss.c: Fix error handling
alejandro-colomar Mar 3, 2026
81cb1e7
lib/nss.c: Move '\n' check earlier
alejandro-colomar Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/nss.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,22 +79,27 @@ nss_init(const char *nsswitch_path) {
}
p = NULL;
while (getline(&line, &len, nssfp) != -1) {
if (stpsep(line, "\n") == NULL) {
fprintf(log_get_logfd(), "%s: Non-text file.\n", nsswitch_path);
Comment thread
alejandro-colomar marked this conversation as resolved.
goto null_subid;
}
if (strprefix(line, "#"))
continue;
if (strlen(line) < 8)
if (strlen(line) < 7)
continue;
if (!strcaseprefix(line, "subid:"))
continue;
p = &line[6];
p = stpspn(p, " \t\n");
p = stpspn(p, " \t");
if (!streq(p, ""))
break;
p = NULL;
}
if (p == NULL) {
goto null_subid;
}
if (stpsep(p, " \t\n") == NULL) {
stpsep(p, " \t");
if (streq(p, "")) {
fprintf(log_get_logfd(), "No usable subid NSS module found, using files\n");
Comment thread
alejandro-colomar marked this conversation as resolved.
// subid_nss has to be null here, but to ease reviews:
goto null_subid;
Expand Down
Loading