Skip to content

Fallback benchmark comparison to dry-run when secrets are unavailable #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharpninja merged 3 commits into from
Mar 21, 2026
Merged

Fallback benchmark comparison to dry-run when secrets are unavailable #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff17f1d
Initial plan
Copilot Mar 21, 2026
a17fc56
Fallback benchmark workflow to dry-run without secrets
Copilot Mar 21, 2026
43c7542
Refine benchmark workflow dry-run fallback
Copilot Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/benchmark-comparison.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,34 @@ jobs:
npm install -g azurite
azurite --silent --skipApiVersionCheck --location /tmp/azurite --debug /tmp/azurite-debug.log &

- name: Select benchmark mode
shell: bash
run: |
if [[ -n "${GRAPHRAG_API_KEY:-}" && -n "${GRAPHRAG_API_BASE:-}" && -n "${AZURE_AI_SEARCH_URL_ENDPOINT:-}" && -n "${AZURE_AI_SEARCH_API_KEY:-}" ]]; then
echo "BENCHMARK_EXTRA_ARG=" >> "$GITHUB_ENV"
echo "Running full benchmark comparison." >> "$GITHUB_STEP_SUMMARY"
else
echo "BENCHMARK_EXTRA_ARG=--dry-run" >> "$GITHUB_ENV"
echo "Benchmark secrets are unavailable; running benchmark comparison in dry-run mode." >> "$GITHUB_STEP_SUMMARY"
fi

- name: Benchmark Python implementation
shell: bash
run: |
uv run python scripts/benchmark_smoke.py run \
--implementation python \
--repo-root "${{ github.workspace }}" \
--output benchmark-python.json
--output benchmark-python.json \
${BENCHMARK_EXTRA_ARG}

- name: Benchmark .NET implementation
shell: bash
run: |
uv run python scripts/benchmark_smoke.py run \
--implementation dotnet \
--repo-root "${{ github.workspace }}" \
--output benchmark-dotnet.json
--output benchmark-dotnet.json \
${BENCHMARK_EXTRA_ARG}

- name: Generate comparison report
run: |
Expand Down
Loading