fix(ui-react): use server-side filtering for device search#6129
Merged
gustavosbarreto merged 1 commit intomasterfrom Apr 7, 2026
Merged
fix(ui-react): use server-side filtering for device search#6129gustavosbarreto merged 1 commit intomasterfrom
gustavosbarreto merged 1 commit intomasterfrom
Conversation
The device search on the main UI page was filtering locally, which only searched within the current page of results. This sends a base64-encoded filter query param to the API instead, matching the Vue UI behavior and searching across all devices.
|
Claude finished @luizhf42's task in 3m 27s —— View job Code Review CompleteReviewed 3 files across code quality, security, testing, TypeScript/React patterns, and architecture — no issues found. The code looks good as-is. Highlights:
If you push additional changes and want a new review, tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Device search on the tenant device list page now queries the API with a base64-encoded filter instead of filtering client-side.
Why
The previous implementation filtered devices locally after fetching, which only searched within the current page (10 devices). With more than one page of devices, search results were incomplete. The Vue UI already sends server-side filters correctly; this aligns the React UI with that behavior.
Changes
buildTagFilterinto a unifiedbuildFilter(search, tags)that combines name and tag filters into a single base64-encoded array. Addedsearchparam to the hook interface..filter()with a debounced (300ms, trimmed) search input that passes the query touseDevicesfor server-side filtering. Page resets to 1 on new input.buildFiltercovering search-only, tags-only, combined, and empty-input cases.Testing