fix(api): place AND operator before connector filter in device list#6131
Merged
gustavosbarreto merged 1 commit intomasterfrom Apr 7, 2026
Merged
fix(api): place AND operator before connector filter in device list#6131gustavosbarreto merged 1 commit intomasterfrom
gustavosbarreto merged 1 commit intomasterfrom
Conversation
|
Claude finished @gustavosbarreto's task in 2m 29s —— View job Code Review CompleteReviewed 2 files across code quality, security, testing, Go patterns, and architecture — no issues found. The code looks good as-is. The fix correctly moves the To request another review round, comment |
…andler The connector/platform filter appended the AND operator after the property, so it was OR'd with user filters instead of AND'd, effectively returning all devices regardless of the user's search filter.
e36630a to
704627a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Matchprocesses operators as prefix (applies to the next condition), the platform filter was OR'd with user filtersWHERE (name ILIKE '%foo%') OR (platform <> 'connector')instead of AND, returning all non-connector devices regardless of the user's search