Fixes #223 : remove incompatible numpy pin from webui requirements#224
Fixes #223 : remove incompatible numpy pin from webui requirements#224randyy179 wants to merge 2 commits intoshiyu-coder:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes an incompatible NumPy version pin from the Web UI dependency set to make webui/requirements.txt installable again alongside pandas==2.2.2, including on Python 3.12.
Changes:
- Removed
numpy==1.24.3fromwebui/requirements.txtto resolve the unsatisfiable pandas/NumPy constraints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,6 @@ | |||
| flask==2.3.3 | |||
| flask-cors==4.0.0 | |||
There was a problem hiding this comment.
webui/app.py and webui/run.py import NumPy directly, but webui/requirements.txt no longer lists numpy as an explicit dependency. Even though pandas currently pulls NumPy transitively, this makes the Web UI’s direct dependency set unclear and can break installs that don’t resolve transitive deps. Consider adding numpy back without the incompatible hard pin (or with a lower-bound consistent with pandas’ requirements).
| flask-cors==4.0.0 | |
| flask-cors==4.0.0 | |
| numpy>=1.22.4 |
There was a problem hiding this comment.
Good catch. NumPy is a direct dependency because both webui/app.py and webui/run.py import it directly.
I updated webui/requirements.txt to keep NumPy explicit while removing the incompatible hard pin. It now uses a compatible lower bound (numpy>=1.26.0) alongside pandas==2.2.2.
Fixes webui/requirements.txt has unsatisfiable pandas/numpy constraints on Python 3.12 #223