Conversation
…d frame The empty NSToolbar with .unified style was allocating toolbar space that interfered with NavigationSplitView's sidebar/detail layout. Removing it and switching from min constraints to a fixed frame matches the working pattern used in pynb/mdnb.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01b20ca569
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| .navigationSplitViewStyle(.balanced) | ||
| .frame(minWidth: 680, minHeight: 450) | ||
| .frame(width: 680, height: 450) |
There was a problem hiding this comment.
Using a fixed .frame(width: 680, height: 450) on the root NavigationSplitView makes the settings content lock to that exact size, so when users resize the settings window (it is still created with the .resizable style mask in AppDelegate), the split view no longer grows with the window and can leave unused blank space instead of expanding the detail/sidebar layout. This regression was introduced by replacing the previous minimum-size frame and is user-visible whenever the window is resized larger than 680×450.
Useful? React with 👍 / 👎.
Fixed-size settings panel doesn't need to be resizable.
1 participant
Summary