Bump embedded worktrunk to 0.27.0 and auto-upgrade managed installs#15
Bump embedded worktrunk to 0.27.0 and auto-upgrade managed installs#15
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cec77e9de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| enum WorktrunkInstaller { | ||
| private struct Release { | ||
| static let version = "0.22.0" | ||
| static let version = "0.27.0" |
There was a problem hiding this comment.
Updating Release.version to 0.27.0 does not actually upgrade existing installs because installPinnedWorktrunkIfNeeded() still exits as soon as wt and git-wt are present (WorktrunkInstaller.swift:50-52), without checking their version. In the common upgrade path (user already has 0.22.0 installed), this leaves stale binaries in place, so the new pinned version is never applied and any 0.27.0-dependent behavior will not take effect.
Useful? React with 👍 / 👎.
Reinstall when an older Ghostree-managed binary is detected by tracking the installed version in a .worktrunk-version marker file. Non-managed installs (Homebrew, custom path) are unaffected.
nicosuave
force-pushed
the
nicosuave/bump-ghostrunk
branch
from
2cec77e to
bda762d
Compare
nicosuave
changed the title
1 participant
Summary
.worktrunk-versionmarker file so Ghostree-managed installs get upgraded automatically on next launchGHOSTTY_WORKTRUNK_BIN, system paths) are completely unaffected