Skip to content

Fix diff sidebar spinner pulsing on background refresh #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosuave merged 1 commit into from
Feb 26, 2026
Merged

Fix diff sidebar spinner pulsing on background refresh #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions macos/Sources/Features/GitDiff/GitDiffSidebarState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,11 @@ final class GitDiffSidebarState: ObservableObject {

let start = DispatchTime.now().uptimeNanoseconds

isLoading = true
defer { isLoading = false }
// Only show the loading spinner for forced (user-initiated) refreshes,
// not for background poll/watch refreshes, to avoid visual pulsing.
let showLoading = force
if showLoading { isLoading = true }
defer { if showLoading { isLoading = false } }

let root = await store.repoRoot(for: effectiveCwd.path)
repoRoot = root
Expand Down
Loading