Skip to content

fix: remove explicit nil from optional properties #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosuave merged 1 commit into from
Feb 22, 2026
Merged

fix: remove explicit nil from optional properties #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion macos/Sources/Features/Terminal/BaseTerminalController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class BaseTerminalController: NSWindowController,

/// A managed tab/window title that takes precedence over user-initiated overrides.
/// Used for features that pin the title to a specific concept (e.g. worktree tabs).
var managedTitleOverride: String? = nil {
var managedTitleOverride: String? {
didSet { applyTitleToWindow() }
}

Expand Down
10 changes: 5 additions & 5 deletions macos/Sources/Features/Terminal/TerminalController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ final class WorktrunkSidebarState: ObservableObject {
@Published var columnVisibility: NavigationSplitViewVisibility
@Published var expandedRepoIDs: Set<UUID> = []
@Published var expandedWorktreePaths: Set<String> = []
@Published var selection: SidebarSelection? = nil
@Published var selection: SidebarSelection?
@Published var isApplyingRemoteUpdate: Bool = false

init(
Expand Down Expand Up @@ -211,12 +211,12 @@ class TerminalController: BaseTerminalController, TabGroupCloseCoordinator.Contr
private var worktrunkSidebarSyncCancellables: Set<AnyCancellable> = []
private var worktrunkSidebarSyncApplyingRemoteUpdate: Bool = false
private let gitDiffSidebarState = GitDiffSidebarState()
private var lastTabSwitchRefreshAt: Date? = nil
private var lastTabSwitchRefreshAt: Date?
private let tabSwitchRefreshThrottle: TimeInterval = 0.15
private var pendingTabSwitchRefresh: DispatchWorkItem? = nil
private var lastTabSwitchSurfaceID: UUID? = nil
private var pendingTabSwitchRefresh: DispatchWorkItem?
private var lastTabSwitchSurfaceID: UUID?

private(set) var worktreeTabRootPath: String? = nil {
private(set) var worktreeTabRootPath: String? {
didSet { syncWorktreeTabTitle() }
}

Expand Down
Loading