refactor(application-header): prevent NG0956 warning in launchpad fac…#1696
Merged
spike-rabbit merged 1 commit intomainfrom Mar 24, 2026
Merged
refactor(application-header): prevent NG0956 warning in launchpad fac…#1696spike-rabbit merged 1 commit intomainfrom
spike-rabbit merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the @for loop in si-launchpad-factory.component.html to use track $index instead of track category. This change is appropriate because the category objects are dynamically created within a computed signal, leading to unstable object identities. Tracking by $index resolves potential performance issues and warnings related to inefficient DOM updates.
spike-rabbit
requested changes
Mar 24, 2026
spliffone
force-pushed
the
refactor/ng0956-trackby-launchpad
branch
from
a692ca8 to
af41fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tory
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: