feat: add legacy sidecar support for pre-1.28 Kubernetes clusters#129
Open
feat: add legacy sidecar support for pre-1.28 Kubernetes clusters#129
Conversation
Continuous validation previously required native sidecars (restartPolicy: Always on init containers), which is only available on Kubernetes 1.28+. This adds automatic version detection and a fallback strategy for older clusters: a one-shot init container for initial validation plus a traditional sidecar container for periodic re-validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds --force-legacy-sidecar flag (and FORCE_LEGACY_SIDECAR env var) to force legacy sidecar mode on clusters that support native sidecars. This enables e2e testing of the legacy path on modern Kind clusters. The e2e test enables the flag via env var on the operator deployment, deploys a ModelValidation CR with continuous validation, and verifies that both the one-shot init container and legacy sidecar container are injected correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-initialflag tovalidation-agentso the legacy sidecar skips redundant initial validation already performed by the init containerChanges
internal/webhooks/version.goNativeSidecarSupport()queries K8s API server versioninternal/webhooks/pod_webhook.goNewPodInterceptoracceptsnativeSidecarSupportbool; newbuildLegacySidecarContainer; idempotency check covers both init and regular containerscmd/validation-agent/main.go--skip-initialflagcmd/main.gointernal/constants/images.goModelValidationSidecarContainerNameconstantapi/v1alpha1/modelvalidation_types.gointernal/webhooks/pod_webhook_legacy_test.goTest plan
make test)🤖 Generated with Claude Code