Skip to content

Add fix for allowing urls without http/https prefix #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibaultmol wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Add fix for allowing urls without http/https prefix #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion github-issue-to-markdown.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,12 @@ <h1>Convert GitHub issue to markdown</h1>

function parseGitHubUrl(url) {
try {
const urlObj = new URL(url)
// Normalize URL by adding https:// if no protocol is present
let normalizedUrl = url.trim()
if (!normalizedUrl.match(/^https?:\/\//)) {
normalizedUrl = 'https://' + normalizedUrl
}
const urlObj = new URL(normalizedUrl)
const [, owner, repo, , number] = urlObj.pathname.split('/')
if (!owner || !repo || !number) {
throw new Error('Invalid URL format')
Expand Down Expand Up @@ -601,6 +606,16 @@ <h1>Convert GitHub issue to markdown</h1>
assertDeepEqual(result, { owner: 'owner', repo: 'repo', number: '123' })
})

test('parseGitHubUrl: URL without protocol (adds https://)', () => {
const result = parseGitHubUrl('github.com/owner/repo/issues/123')
assertDeepEqual(result, { owner: 'owner', repo: 'repo', number: '123' })
})

test('parseGitHubUrl: URL with http:// protocol', () => {
const result = parseGitHubUrl('http://github.com/owner/repo/issues/456')
assertDeepEqual(result, { owner: 'owner', repo: 'repo', number: '456' })
})

test('parseGitHubUrl: valid PR URL', () => {
const result = parseGitHubUrl('https://github.com/simonw/sqlite-utils/pull/456')
assertDeepEqual(result, { owner: 'simonw', repo: 'sqlite-utils', number: '456' })
Expand Down