Open
Conversation
* Wrokaround the SMT issue for chess by settin the cpu to 2 for spdk-proxy-container
* fix: enforce HT-aware SPDK core alignment and dynamic CPU limits
- build_unisolated_stride: add nodes_per_socket param; pre-adjust
num_unisolated so remaining SPDK cores are divisible by 4 (nodes_per_socket>=2, HT enabled) or 2 (HT enabled), preserving pool-stride and HT pair selection;
return adjusted num_unisolated alongside the core list - generate_core_allocation: unpack new return value and pass nodes_per_socket into build_unisolated_stride
- storage_deploy_spdk.yaml.j2: set cpu for spdk-proxy-container and copy-script
to 2 if HT enabled and CPU topology enabled, 1 if CPU topology enabled without
HT, omit cpu limit/request entirely when CPU topology is disabled
- kubernetes.py: pass HT_ENABLED (via is_hyperthreading_enabled_via_siblings)
to the pod template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrokaround the SMT issue for chess by settin the cpu to 2 for spdk-proxy-container
fix: enforce HT-aware SPDK core alignment and dynamic CPU limits
num_unisolated so remaining SPDK cores are divisible by 4 (nodes_per_socket>=2, HT enabled) or 2 (HT enabled), preserving pool-stride and HT pair selection;
return adjusted num_unisolated alongside the core list - generate_core_allocation: unpack new return value and pass nodes_per_socket into build_unisolated_stride
to 2 if HT enabled and CPU topology enabled, 1 if CPU topology enabled without
HT, omit cpu limit/request entirely when CPU topology is disabled
to the pod template