Draft
Conversation
mxsrc
reviewed
Mar 19, 2026
chart/templates/controller.yaml
Outdated
| name: vela-controller-config | ||
| data: | ||
| VELA_ROOT_PATH: {{ .Values.controller.env.VELA_ROOT_PATH | quote }} | ||
| UVICORN_ROOT_PATH: {{ .Values.controller.env.VELA_ROOT_PATH | quote }} |
Collaborator
There was a problem hiding this comment.
I don't think this will resolve the issue, it basically duplicates what the variable above already does. FastAPI is already aware it's running with a root path, it's just the URL generation that's failing.
See this discussion on the handling: fastapi/fastapi#14038 (reply in thread). It's been a while since I thought about this, but iirc the fix was to adapt the url_path_for helper to use request.url_for(...).path instead of app.url_path_for. But this needs confirmation.
This is required to check on branch creation/modification within which bounds the operation may be conducted.
The recent changes on the resource limit implementation exposed an issue with the implementation of system limits. They shouldnt't be a third, global scope of resources, but rather a default for organization limits on creation. This change addresses this, by introducing a separate, appropriately named table for handling these defaults. The system-level endpoints are removed as they are not needed anymore, and a migration ensures existing system limits are converted to the correct values.
The workflow simply referenced the built image tage, adding the digest ensures helm detects changes and redeploys when a new image is built.
The previous version failed to reuse the existing enum datatype. The change makes sure it is referenced instead.
This reverts commit e547e84.
When using double quotations, values that contain bash instructions will attempt to be resolved, for example credentials using '$' symbols might be invalidated this way. This switches to single quotes for all inputs that are used directly, avoiding this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: simplyblock/vela#218
When the controller generates redirects, they lack the path prefix that the controller runs under,. Instead of /vela/foo the it will redirect to /foo. This happens for example to account for presence/lack of trailing slashes.