This repository was archived by the owner on Jan 3, 2024. It is now read-only.
Handle Invalid JSON in Cargo Output#429
Open
schrieveslaach wants to merge 1 commit intosimrat39:masterfrom
Open
Handle Invalid JSON in Cargo Output#429schrieveslaach wants to merge 1 commit intosimrat39:masterfrom
schrieveslaach wants to merge 1 commit intosimrat39:masterfrom
Conversation
When running all tests of a file, the cargo command prints none JSON strings into stdout. Therefore, the debugging fails because the dap.lua file wasn't prepared for that. This commit makes the JSON parsing of the stdout output more robust by excepting none JSON formatted lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running all tests of a file, the cargo command prints none JSON strings into stdout. Therefore, the debugging fails because the dap.lua file wasn't prepared for that. This commit makes the JSON parsing of the stdout output more robust by excepting none JSON formatted lines.