fix(workflow): optimize loop/parallel regeneration and prevent duplicate agent tools

[waleedlatif1]

Summary

• Optimized workflow store to skip unnecessary loop/parallel regeneration when adding regular blocks
• Added duplicate prevention for agent tools (custom tools, MCP tools, workflows, integrations)
• Edge operations no longer trigger loop/parallel regeneration since edges don't affect containment

Type of Change

• Bug fix
• Performance improvement

Testing

• Added 11 new tests for loop/parallel regeneration optimization
• Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Feb 1, 2026 1:45am

[greptile-apps]

Greptile Overview

Greptile Summary

Optimized workflow store to skip expensive loop/parallel regeneration operations when they're not needed, and added duplicate prevention for agent tools.

Major Changes:

• addBlock: Only regenerates loops when adding a loop block or a child to an existing loop (same for parallels)
• batchAddBlocks: Checks if any block affects loop/parallel structure before regenerating
• batchAddEdges / batchRemoveEdges: Skip regeneration entirely since edges don't affect container structure
• Tool selection UI now prevents duplicate selection of MCP tools, custom tools, workflows, and integrations

Performance Impact:
Previously, every block addition would regenerate both loops and parallels by iterating through all blocks. Now, most operations (adding regular blocks, edge operations) reuse existing loop/parallel state with shallow copies, avoiding expensive iterations.

Confidence Score: 5/5

• Safe to merge - well-tested performance optimization with no breaking changes
• The optimization is sound, comprehensive test coverage validates correctness, and the logic properly handles all edge cases including undo-redo scenarios
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/stores/workflows/workflow/store.ts	Optimized loop/parallel regeneration to skip unnecessary work when adding regular blocks or edges
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx	Added duplicate prevention helpers and early returns for MCP tools, custom tools, workflows, and integrations

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkflowStore
    participant generateLoopBlocks
    participant generateParallelBlocks

    Note over WorkflowStore: Case 1: Add regular block (no parentId)
    User->>WorkflowStore: addBlock(id, type='agent', ...)
    WorkflowStore->>WorkflowStore: Check parentId (undefined)
    WorkflowStore->>WorkflowStore: Create newBlocks
    Note over WorkflowStore: Skip loop/parallel regeneration
    WorkflowStore->>WorkflowStore: set({ loops: {...get().loops}, parallels: {...get().parallels} })

    Note over WorkflowStore: Case 2: Add child to loop
    User->>WorkflowStore: addBlock(id, type='function', parentId='loop-1')
    WorkflowStore->>WorkflowStore: Check parentBlock type (loop)
    WorkflowStore->>generateLoopBlocks: generateLoopBlocks(newBlocks)
    generateLoopBlocks-->>WorkflowStore: Updated loops with child
    WorkflowStore->>WorkflowStore: set({ loops: updatedLoops, parallels: {...get().parallels} })

    Note over WorkflowStore: Case 3: Add edge
    User->>WorkflowStore: batchAddEdges([edge])
    WorkflowStore->>WorkflowStore: Validate and add edge
    Note over WorkflowStore: Edges don't affect loop/parallel structure
    WorkflowStore->>WorkflowStore: set({ loops: {...get().loops}, parallels: {...get().parallels} })

    Note over WorkflowStore: Case 4: Batch add with mixed blocks
    User->>WorkflowStore: batchAddBlocks([loop, child, regular])
    WorkflowStore->>WorkflowStore: Check if any block.type === 'loop'
    WorkflowStore->>WorkflowStore: Check if any block has parentId pointing to loop
    WorkflowStore->>generateLoopBlocks: generateLoopBlocks(newBlocks)
    generateLoopBlocks-->>WorkflowStore: Updated loops
    WorkflowStore->>WorkflowStore: set({ loops: updatedLoops })

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}