[Demon Hunter] Fix Doomsayer trigger asymmetric buff expiration #10921
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
doomsayer_trigger_tguard checks bothdoomsayer_in_combatanddoomsayer_out_of_combatbuffs (line 3161), but only expiresdoomsayer_in_combat(line 3172). If the out-of-combat buff were the active one when the trigger fires, it would not be consumed — allowing a double trigger on the next melee attack.Fix
Expire both buffs unconditionally after the trigger fires.
buff_t::expire()is a no-op on inactive buffs, so both calls are always safe.In practice, the combat state callback (lines 9742-9753) normally swaps to
doomsayer_in_combatbefore the first attack, so this is a latent correctness fix rather than a commonly triggered bug.