[Warlock] Demonic Knowledge hotfix, Diabolist pet updates, and more accurate Hellbent Commander implementation

[millanzarreta]

Demonic Knowledge hotfix

The description and spell data for this talent indicate a chance of 8% (rank 1) and 15% (rank 2), but ingame its average chance was 12.5% ​​(rank 1) and 22.5% (rank 2) based on an RNG model of a deck of cards 10 out of 80 (rank 1) and 18 out of 80 (rank 2).

Blizzard recently announced a hotfix that corrects its chance to its expected values. After testing, it has been verified that the average chance has indeed been reduced to 15% for rank 2 (deck of cards 12 out of 80) and 7.5% for rank 1 (deck of cards 6 out of 12), although the spell data and description for the latter case (rank 1) state 8%.

Logs:

• (rank2) https://www.warcraftlogs.com/reports/CcQWB9nLPxY3tF4A?fight=last&source=1&type=casts&ability=105174
• (rank1) https://www.warcraftlogs.com/reports/bBvWw87QzpnxhLGm?fight=last&source=1&type=casts&ability=105174

There are exactly 12 procs for every 80 HoG casts (for DK rank2), and 6 procs for every 80 HoG casts (for DK rank1). This holds true for over 13+ blocks of 80 HoG casts for each log. This has allowed us to confirm that the Deck of Cards model is being used. Internally, within each block, the distribution of procs appears completely random (the card shuffling seems uniform), as can be seen in the following heatmaps:

• (rank2)

• (rank1)

Pets and Hellbent Commander

Since Hellbent Commander depends on active pets, it is important to model their correct durations, including early despawns when they finish their actions (especially for Diabolist pets).

Furthermore, although an implementation of its buggy behavior was already partially done in #11122 (especially for wild imps), we've analyzed in more detail how this buff updates. All pets seem to contribute to the buff stack, and its stack updates to the correct value on each heartbeat. However, some pets seem to contribute instantly to the buff on their arise and/or demise, while others don't update the stack until the heartbeat. Through in-game testing, we obtained the following table, which has been modeled in SimC:

pet	heartbeat	arise	demise	comment
main_pets	1	1	1
wild_imps_1(hog)	1	1	*	-> -2 stacks on normal/PS demise, -1 stacks on implosion
wild_imps_2(talents)	1	1	*	-> -1 stacks on normal/PS demise, ±0 stacks on implosion
dreadstalker	1	1	1
vilefiend	1	1	-
vilefiend_shadow	1	1	-
vilefiend_fire	1	1	-
tyrant	1	1	-
grimoire_imp_lord	1	1	-
grimoire_fel_ravager	1	1	-
doomguard	1	1	1
doa_demons(apex)	1	-	-
diabolist_mother	1	-	-
diabolist_pit_lord	1	-	-
diabolist_overlord	1	-	-
rampaging_demon_soul	1	-	-