-
Notifications
You must be signed in to change notification settings - Fork 1
Hotfix: Metric size limits #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wk9874
wants to merge
24
commits into
dev
Choose a base branch
from
hotfix/metric_size_limits
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.0.0 Alpha 2 Release
v2.0.0a3 release
v2.0.0 RC 1
2.0.0 release
Update versioning
Create v2.1.1 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix: Metric size limits
Python Version(s) Tested: 3.11
Operating System(s): Ubuntu
📝 Summary
The total grid metric size limit was set to the same as the individual grid metric size limit (50k points, ~50KB). The total limit should be 10MB
This also exposed that the runs would go into lost state even though metrics were still being uploaded. Suspect this is due to the heartbeat thread being joined before the dispatcher thread was joined in _tidy_run or _error, meaning if there are lots of grids left to dispatch, the heartbeat would stop prematurely.
🔍 Diagnosis
Veeeery slow performance when loading large FDS simulations with lots of grid data. Run would become lost even while still uploading grid metrics.
🔄 Changes
Change the total metrics limit to be 1e6, and moved the joining of the heartbeat thread to below the joining of the dispatcher thread in
_errorand_tidy_run✔️ Checklist