Conversation
fix containers cleanup bug
badrogger
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility function,
rm_legacy_containers, to remove legacy Docker containers with names matching theskale_prefix. The function is integrated into various node update and shutdown operations to ensure old containers are properly cleaned up. Comprehensive tests are also added to verify the removal logic.Container cleanup improvements:
rm_legacy_containersfunction indocker_utils.py, which removes all containers with names matching theskale_prefix.rm_legacy_containersinto the update and shutdown flows for both SKALE and FAIR nodes inbase.pyandfair.py, ensuring legacy containers are removed during these operations. [1] [2] [3] [4] [5]Testing enhancements:
rm_legacy_containersto the test imports and implementedtest_rm_legacy_containersto verify that legacy containers are properly removed. [1] [2]get_all_skaled_containersto validate container discovery logic.Code organization:
base.pyandfair.pyto include the new utility. [1] [2]