Skip to content

develop to beta - fix legacy containers#973

Merged
dmytrotkk merged 3 commits intobetafrom
develop
Apr 15, 2026
Merged

develop to beta - fix legacy containers#973
dmytrotkk merged 3 commits intobetafrom
develop

Conversation

@dmytrotkk
Copy link
Copy Markdown
Collaborator

This pull request introduces a new utility function, rm_legacy_containers, to remove legacy Docker containers with names matching the skale_ prefix. The function is integrated into various node update and shutdown operations to ensure old containers are properly cleaned up. Comprehensive tests are also added to verify the removal logic.

Container cleanup improvements:

  • Added the rm_legacy_containers function in docker_utils.py, which removes all containers with names matching the skale_ prefix.
  • Integrated rm_legacy_containers into the update and shutdown flows for both SKALE and FAIR nodes in base.py and fair.py, ensuring legacy containers are removed during these operations. [1] [2] [3] [4] [5]

Testing enhancements:

  • Added rm_legacy_containers to the test imports and implemented test_rm_legacy_containers to verify that legacy containers are properly removed. [1] [2]
  • Added a real Docker test for get_all_skaled_containers to validate container discovery logic.

Code organization:

  • Updated import statements in base.py and fair.py to include the new utility. [1] [2]

@dmytrotkk dmytrotkk merged commit 2c4d370 into beta Apr 15, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants