This repository was archived by the owner on Oct 30, 2018. It is now read-only.
inputbar left button: fixes text-only button not being displayed#654
Open
soscomp wants to merge 1 commit intoslackhq:masterfrom
Open
inputbar left button: fixes text-only button not being displayed#654soscomp wants to merge 1 commit intoslackhq:masterfrom
soscomp wants to merge 1 commit intoslackhq:masterfrom
Conversation
When using only a label for the left button it previously wasn't displayed at all. This was due to constraints recalculation was only done when the image is changed but not when the label is changed. Now label is monitored for changes too and constraints are coreetly updated therefore displaying text-only buttons corretly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Test strategy