This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Provide a warning to implementor when container view has mismatched configuration#681
Open
rromanchuk wants to merge 2 commits intoslackhq:masterfrom
Open
Provide a warning to implementor when container view has mismatched configuration#681rromanchuk wants to merge 2 commits intoslackhq:masterfrom
rromanchuk wants to merge 2 commits intoslackhq:masterfrom
Conversation
…may cuase SLKTextViewController to calculate incorrect bottom margin calculations. slackhq#668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedding
SLKTextViewControllerin a container view will most likely cause an incorrect bottom margin calculation. Especially when storyboarding as #668PR Summary
Scream at user if there is a tabbar inside a container view and its configuration differs from its parent.
Related Issues
Fixes for #668 and #680
Test strategy
NOOP, adds a console warning to potentially reduce headaches. This could and probably be branched, as it's almost never what the implementor intended. Or simply could take the parentViewController's properties when not null (meaning it's in a container). When storyboarding and running, the tabbar isn't shown, and respects the parent's setting, but
SlackTextViewControllerreads this property on the container and provides an incorrect margin making this very difficult to track down and debug.