Splitscreen disconnection fix + mob null pointer checks.#1043
Open
DeveloperExotic wants to merge 1 commit intosmartcmd:mainfrom
Open
Splitscreen disconnection fix + mob null pointer checks.#1043DeveloperExotic wants to merge 1 commit intosmartcmd:mainfrom
DeveloperExotic wants to merge 1 commit intosmartcmd:mainfrom
Conversation
Contributor
|
we should wait for the @kuwacom server to merge main, this breaks the non-host splitscreen. but this is nice in the meanwhile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the instant disconnection that happens after connecting to an online game,
Including a null pointer check for mobs, which prevents the game from crashing.
Changes
Previous Behavior
Instant disconnection from a networked game
Root Cause
The local player is assigned smallId=1 by the server and stored in m_player[1]. The old code returned m_player[1] when checking user index 1 (the split screen slot) making the game think there was a second local player who wasnt signed in (making the client disconnect).
New Behavior
You wont disconnect, and the game wont crash.
AI Use Disclosure
No AI needed.