Fix gamepad hot-plug detection (controller connected after launch now works)#1045
Open
NSDeathman wants to merge 1 commit intosmartcmd:mainfrom
Open
Fix gamepad hot-plug detection (controller connected after launch now works)#1045NSDeathman wants to merge 1 commit intosmartcmd:mainfrom
NSDeathman wants to merge 1 commit intosmartcmd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the game checks
InputManager.IsPadConnected(0)once at startup to determine whether a gamepad is available. If a controller is connected after the program has already started, this flag remainsfalse, and the input system never switches to gamepad mode — even when buttons or sticks are used.Solution
Remove the static
IsPadConnectedcheck from the main input loop. Instead, directly evaluate whether any gamepad input (buttons or stick movements) is present. The underlying input functions (ButtonPressed,GetJoypadStick_...) safely returnfalse/0.0fwhen no controller is connected. Once a gamepad is plugged in and the player uses it,controllerUsedbecomestrueand the input mode switches to gamepad as expected.This change:
Testing
Verified that a gamepad connected after the game is running is immediately recognized as soon as a button is pressed. No regressions observed with keyboard/mouse input.