Add SettingDataVersion and Introduce SettingFixer#1097
Draft
jvnpr wants to merge 1 commit intosmartcmd:mainfrom
Draft
Add SettingDataVersion and Introduce SettingFixer#1097jvnpr wants to merge 1 commit intosmartcmd:mainfrom
jvnpr wants to merge 1 commit intosmartcmd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new game setting to store settings data version, and creates the SettingFixer function to deal with conversions.
Changes
Previous Behavior
The game has no way of knowing what build a settings file was created for, or if any conversions need to be performed.
New Behavior
Setting files now store a data version.
Fix Implementation
Creates a new game setting
eGameSetting_SettingDataVersionand associateduiSettingDataVersionto store the current version of a settings file. A new function inConsoles_AppscalledSettingFixerhas been created to compare a setting file's data version and perform necessary conversions to other settings.SettingsFixeris called once during initialization from withinWindows64_minecraft.AI Use Disclosure
No AI was used to author these changes or pull request.
Related Issues